Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the Core Debug Level gives compile errors #156

Open
PhotoKevin opened this issue Jul 7, 2022 · 3 comments
Open

Setting the Core Debug Level gives compile errors #156

PhotoKevin opened this issue Jul 7, 2022 · 3 comments

Comments

@PhotoKevin
Copy link

Using the Arduino 2.0 IDE, setting Tools->Core Debug Level to Debug gives compile errors. Levels None and Warn are ok.


In file included from ...\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.4\cores\esp32/esp32-hal.h:76,
                 from ...\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.4\cores\esp32/Arduino.h:36,
                 from ...\Documents\Arduino\libraries\ESP32_HTTPS_Server\src\WebsocketHandler.hpp:4,
                 from ...\Documents\Arduino\libraries\ESP32_HTTPS_Server\src\WebsocketHandler.cpp:1:
...\Documents\Arduino\libraries\ESP32_HTTPS_Server\src\WebsocketHandler.cpp: In function 'void httpsserver::dumpFrame(httpsserver::WebsocketFrame)':
...\Documents\Arduino\libraries\ESP32_HTTPS_Server\src\WebsocketHandler.cpp:20:5: error: 'TAG' was not declared in this scope
     TAG,
     ^~~
...\AppData\Local\Arduino15\packages\esp32\hardware\esp32\2.0.4\cores\esp32/esp32-hal-log.h:127:72: note: in definition of macro 'log_i'
 #define log_i(format, ...) log_printf(ARDUHAL_LOG_FORMAT(I, format), ##__VA_ARGS__)
                                                                        ^~~~~~~~~~~
...\Documents\Arduino\libraries\ESP32_HTTPS_Server\src\WebsocketHandler.cpp:19:3: note: in expansion of macro 'ESP_LOGI'
   ESP_LOGI(
   ^~~~~~~~

exit status 1
@squonk11
Copy link
Contributor

squonk11 commented Jul 8, 2022

I think, that
#include "esp_log.h"
is missing?

@PhotoKevin
Copy link
Author

#160 says adding esp_log.h doesn't fix it. I hope it's maintained, I want https.

@WayneKeenan
Copy link

In esp32_https_server/src/WebsocketHandler.cpp change:

ESP_LOGI(
         TAG,

to:

HTTPS_LOGI(

frwololo added a commit to frwololo/PS4_PS5-ESP8266-Server that referenced this issue Sep 6, 2023
This adds support for ESP32.

*** TESTS
Tested:
ESP32 Support fully tested in online mode (Tested with ESP32_DevkitC_V4):
- DNS: playstation.net redirected ok, playstation.com blocked ok
- HTTPS: works ok on PC (with of course certificate warning) and ok on PS5
- PS4 Tests: User Guide redirect works, Tested GoldHEN 2.3 on PS4
- PS5 Tests: User Guide Redirect Works, Tested SpecterDev's exploit on PS5

Untested:
- offline mode not tested
- ESP8266 not fully tested with these changes. It is supposed to have no impact on ESP8266.

**** ESP32 Compilation
For people who want to compile this:
- IP_NAPT errors: Some SDKs don't have NAT support enabled for ESP32 so I had to use an unofficial build of the ESP32 Library for Arduino. See:  espressif/arduino-esp32#6421 (comment)

- TAG ESP_LOGI errors: ESP32_HTTPS_SERVER seems to have some code incompatible with some SDKs, I had to manually edit one of the files, see:  fhessel/esp32_https_server#156 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants