Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killing of process is not detected #3

Open
cornelk opened this issue Apr 18, 2020 · 2 comments
Open

Killing of process is not detected #3

cornelk opened this issue Apr 18, 2020 · 2 comments

Comments

@cornelk
Copy link

cornelk commented Apr 18, 2020

it should at least show a WARN error message

@fgrosse
Copy link
Owner

fgrosse commented Apr 18, 2020

If the process exits with a zero status code, its counted as normal finish of the service. I think you can only detect a normal shutdown when you run with verbose (debug) logs. Maybe it should be info instead?

@fgrosse
Copy link
Owner

fgrosse commented Apr 18, 2020

I think actually you should already see this info log message?

prox/executor.go

Lines 153 to 165 in 57be557

switch message.status {
case statusSuccess:
logger.Info("Process finished successfully", zap.String("process_name", name))
case statusInterrupted:
logger.Info("Process was interrupted", zap.String("process_name", name))
case statusError:
logger.Error("Process error", zap.String("process_name", name), zap.Error(message.err))
if firstErr == nil {
firstErr = message.err
firstErrProcess = name
}
interruptAll()
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants