Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loadingPlayersQueue not merged properly #35

Closed
TRHeliad opened this issue Aug 7, 2023 · 2 comments
Closed

loadingPlayersQueue not merged properly #35

TRHeliad opened this issue Aug 7, 2023 · 2 comments
Labels
status: approved type: bug where: internal process

Comments

@TRHeliad
Copy link

TRHeliad commented Aug 7, 2023 •
edited
Loading

The line

TableKit.MergeArrays(loadingPlayersQueue[player][identifier], content)

in ServerProcess I think was meant to be

loadingPlayersQueue[player][identifier] = TableKit.MergeArrays(loadingPlayersQueue[player][identifier], content)

since the TableKit method creates and returns a new table for the merge instead of modifying the passed table.

Maybe you could also try using table.move to put content into the queue instead of using MergeArrays so that you don't create a new table unnecessarily.
@ffrostfall
Copy link
Owner

Yeah, this seems right. will fix

@ffrostfall
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: approved type: bug where: internal process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TRHeliad @ffrostfall