Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator Bugs #905

Closed
9 tasks done
DavidMinarsch opened this issue Mar 7, 2020 · 0 comments
Closed
9 tasks done

Generator Bugs #905

DavidMinarsch opened this issue Mar 7, 2020 · 0 comments
Assignees
Labels
bug Something isn't working cli Issues related to the CLI tool `aea`

Comments

@DavidMinarsch
Copy link
Contributor

DavidMinarsch commented Mar 7, 2020

Is your feature request related to a problem? Please describe.
A small bugs are present in the generator:

Screenshot 2020-03-08 at 10 50 18

  • repeat usage of variables ("key, value"). Mypy complains and we should use unique and descriptive names for these variables:
    Screenshot 2020-03-11 at 14 34 56

  • custom types not correctly declared when tac protocol is generated:
    Screenshot 2020-03-11 at 14 34 14

  • in serialisation.py: 'packages.fetchai.protocols.tac.custom_types.ErrorInfo' imported but unused

  • pt:list[pt:str] generates a tuple in oef protocol. explain this in the docs!

  • add type declaration in decoding logic or serialisation performative_content = dict() # type: Dict[str, Any]

Describe the solution you'd like
Fix the above.

@DavidMinarsch DavidMinarsch added bug Something isn't working cli Issues related to the CLI tool `aea` labels Mar 8, 2020
@5A11 5A11 changed the title Generator bugs Generator To-Dos Mar 24, 2020
@5A11 5A11 changed the title Generator To-Dos Generator Bugs Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Issues related to the CLI tool `aea`
Projects
None yet
Development

No branches or pull requests

2 participants