Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Fest fails to compile with latest nightly #11

Closed
ghost opened this issue Mar 30, 2018 · 4 comments
Closed

Fest fails to compile with latest nightly #11

ghost opened this issue Mar 30, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Mar 30, 2018

Fest fails to compile on the latest version of rust-nightly with an error in futures-await, possibly need to update the version of ruma-client in use, and/or ruma-client's dependancies.

@jplatte
Copy link
Contributor

jplatte commented Apr 2, 2018

I'm aware of the issue. On it.

@jplatte
Copy link
Contributor

jplatte commented Apr 2, 2018

So unless we use unsafe, this is blocked on alexcrichton/futures-await#79 (as you seem to have figured out yourself). I'd prefer to just wait for a fix for that issue, and to keep using an older Nightly until then.

@ghost
Copy link
Author

ghost commented Apr 2, 2018

I've been told it's perfectly fine to use unsafe to fix this since it's just futures-await code, and they never return unmovable generators. But if you want to wait that's fine.

@jplatte
Copy link
Contributor

jplatte commented Apr 12, 2018

Fixed in 863d75e

@jplatte jplatte closed this as completed Apr 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant