Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better dynamic theming support #62

Closed
fennifith opened this issue Feb 14, 2019 · 1 comment
Closed

Better dynamic theming support #62

fennifith opened this issue Feb 14, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@fennifith
Copy link
Owner

The current implementation sort of requires you to implement the fragment in your own activity and call setTheme(int) yourself, recreating the activity on each theme change, which - while workable - doesn't really provide the best implementation for most projects. Proposed changes are to implement .withTheme(int) and .withDarkTheme(boolean) methods in Attribouter, along with improving how the activity handles its toolbar / icon colors.
@fennifith fennifith added the enhancement New feature or request label Feb 14, 2019
@fennifith fennifith mentioned this issue Apr 21, 2019
Closed
@fennifith
Copy link
Owner Author

Update, quite a while later: with the recent addition of the .DayNight theme in develop, I'm seeing this as less important, but it could still be a nice utility to have.

@fennifith fennifith mentioned this issue Jun 27, 2020
Closed
This was referenced Mar 18, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@fennifith