-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ctrl+C in Powershell and CMD profiles doesn't break current line, but does in WSL #91
Comments
Might by related to WinPTY, I expect this to become better once we support ConPTY. Does this cause any problem on your side? Copy keybinding should have no influence on this, it only listens for ctrl+c when something is selected |
Not sure what you are asking, does what cause a problem on my side? maybe relevant: vercel/hyper#1121, microsoft/node-pty#216 |
Does the inconsistent line breaking cause any issue for you? From my perspective this is just a bit odd, but nothing that breaks anything 😅 |
I am very used to it, when I make a typo early in the line or realize I forgot to do something before what I started typing (like committing before pushing) I just do Ctrl+C and start over. And if it works in the native Windows terminals I think it should work here, right? The Hyper terminal issue I linked above is all about this so I think a lot of other people do it too: vercel/hyper#1121 (comment) Here is a fix supposedly, to be released in WinPTY 0.4.4: rprichard/winpty@c9ce3ad Since a new WinPTY version hasn't been released in over a year, maybe it would be worth it to just use the current code from master? |
I got it working by building winpty from master: https://i.imgur.com/dVJm2PB.png |
Normally in Powershell and Command Prompt terminals, pressing
Ctrl+C
breaks what you've typed on the current line and goes to a new line, but this only works in WSL tabs in Fluent Terminal.What happens in
powershell.exe
: https://i.imgur.com/rBWlAls.pngWhat happens in WSL tabs in Fluent Terminal: https://i.imgur.com/Dh7VDtG.png
What happens in Powershell tabs in Fluent Terminal: https://i.imgur.com/5hDFY4U.png
Maybe the Copy keybinding is interfering..?
Also, I really love this project. I feel like this is the terminal Windows 10 should have had from the beginning. If you have a PayPal I would love to donate what I can :)
The text was updated successfully, but these errors were encountered: