Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to notify that text has been copied #192

Closed
felixse opened this issue Jan 31, 2019 · 7 comments
Closed

Add option to notify that text has been copied #192

felixse opened this issue Jan 31, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@felixse
Copy link
Owner

felixse commented Jan 31, 2019

As @skipmeister123 suggested in #65 we should add an option to show a little notification (similar to the resize info) that text has ben copied to the clipboard

@felixse felixse added the enhancement New feature or request label Jan 31, 2019
@AndrewKralovec
Copy link
Contributor

@felixse , should we reuse the re-size notification or create a separate one ? The logic would stay mostly the same.

@hanskokx
Copy link
Contributor

hanskokx commented Mar 27, 2019 via email

@AndrewKralovec
Copy link
Contributor

Would you leave the notifications hooked up to the ViewModel, and then create class to do the logic or would you create an custom control?

If its the former, does that class go under services dir or should it kept in the view model dir ?

@hanskokx
Copy link
Contributor

hanskokx commented Mar 27, 2019 via email

@AndrewKralovec
Copy link
Contributor

Okay, I'll give this task a shot as my second ever commit. I moved the Overlay logic into a Overlay class,(since we already use a notification class for the toast). Once i figure out why the view model is not binding to the overlay class attributes, it'll be easy to extend it to show an overlay for the copied text and whatever else its needed for.

https://github.com/AndrewKralovec/FluentTerminal/tree/DEV/CopiedTextOverlay

@felixse
Copy link
Owner Author

felixse commented Mar 28, 2019

You are having problems with the bindings because your properties are not emitting the NotifyPropertyChangedEvent. I think the Overlay should actually be a ViewModel, that way you can inherit from ViewModelBase, then you can use the Set(ref _field, value) method to update the underlying field and raise the event.

@AndrewKralovec
Copy link
Contributor

@felixse , Yeah i believe you are correct. I was thinking the same after i developed out the class. I appreciate the input. Most of my experience is in ASP.NET Core, and i hope to become better at Universal apps contributing to the project.

I don't however, think it would be a good idea to repeat the overlay control elements for different overly information. I'll have to figure out how to pass the resize values to the control via an event, and not pass them as fields, otherwise whats the point of creating a control. You could just rename the resize methods to something generic and just changing the text for the desired overlay, be it the resize text, copied text, etc.

Once again thanks for the responses, @felixse , @skipmeister123. This is great project and I appreciate the ability to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants