Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with build group changes #242

Closed
msimacek opened this issue Feb 19, 2018 · 3 comments
Closed

Deal with build group changes #242

msimacek opened this issue Feb 19, 2018 · 3 comments
Assignees

Comments

@msimacek
Copy link
Contributor

There are upcoming changes in build group in rawhide (removal of gcc). Koschei currently kinda assumes that build group is immutable, so when it changes, it will cause incorrect resolutions as builds that were still done with gcc in build group might be resolved without it or vice versa.
I think we should either:

  • Get the build group from koji at the given history point. It has event id, so it should be possible to get it at repo's create_event (but might be one-off, I'd need to read the code).
  • Parse it from comps.xml. We already download those (because dnf needs it). That would be closer to what koji builders actually do.

@mizdebsk WDYT?

@mizdebsk
Copy link
Member

Group listings are versioned, so we could definitely take advantage of this.

@msimacek
Copy link
Contributor Author

Which way do you think is better?

@mizdebsk
Copy link
Member

I think it would be better to use Koji Hub API to get historical group contents (option nr 1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants