'bodhi overrides edit --expire' finishes with "Running koji wait-repo ..."

[juhp]

Running bodhi overrides edit --expire ... finishes with the output "Running koji wait-repo ...".
But then finishes anyway. This looks like erroneous output to me - while mostly harmless it is a bit confusing.

I am using bodhi-client-6.0.1-4.fc37 - here is an example:

$ bodhi overrides edit --expire rpmbuild-order-0.4.10-1.fc35
============================================================
     rpmbuild-order-0.4.10-1.fc35
============================================================
  Submitter: petersen
  Expiration Date: 2022-11-20 08:00:59
  Notes: No explanation given...
  Expired: True


Running koji wait-repo f35-build --build=rpmbuild-order-0.4.10-1.fc35
$ 

Since I didn't specify --wait, just finishing is fine, but the "Running koji..." message should not appear in this case I think?

[mattiaverga]

Looks like --wait is the default:

bodhi/bodhi-client/bodhi/client/cli.py

Lines 150 to 161 in 31c8358

	# Common options for the overrides save and edit command
	save_edit_options = [
	click.argument('nvr'),
	click.option('--duration', default=7, type=click.INT,
	help='Number of days the override should exist.'),
	click.option('--notes', default="No explanation given...",
	help='Notes on why this override is in place.'),
	click.option('--wait/--no-wait', is_flag=True, default=True,
	help='Wait and ensure that the override is active'),
	staging_option,
	url_option,
	debug_option]

[mattiaverga]

After re-reading I now understand the confusion... we just have to change the default to --no-wait when --expire is passed as argument.