Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle EPEL buildroot overrides #4737

Closed
gotmax23 opened this issue Sep 9, 2022 · 4 comments · Fixed by #5554
Closed

Properly handle EPEL buildroot overrides #4737

gotmax23 opened this issue Sep 9, 2022 · 4 comments · Fixed by #5554

Comments

@gotmax23
Copy link
Contributor

gotmax23 commented Sep 9, 2022

The epel8-next-build and epel9-next-build koji tags inherit packages from the epel8 and epel9 tags, respectively, but they don't inherit from epelX-override due to limitations in Koji (@nirik and I discussed this). However, when you create an override in Bodhi for a plain EPEL 8/9 package, Bodhi only tags the build into epelX-override. I propose either making this a special case and always tagging EPEL overrides into both epelX-override and epelX-next-override or allowing users to configure this.

This should only happen one way, though. Overrides for epelX packages should be tagged into both tags, but overrides for epelX-next packages should only be tagged into epelX-next-override.

@mattiaverga
Copy link
Contributor

Would the above proposed solution be acceptable?

@nirik
Copy link
Member

nirik commented Dec 5, 2023

Yeah, I suppose so. :( The epel10 setup will be much nicer here.

One nit, theres: "epel-9.override-extend=EPEL-9N,EPEL-8" in the comment, but that should be EPEL-9 there? or just EPEL9-N and nothing more? we don't want to tag epel9 things into epel8...

@mattiaverga
Copy link
Contributor

mattiaverga commented Dec 6, 2023

Well, the comment is only meant to denote that it can inherit from multiple releases listed in CSVs (if have ever need to).
The ansible PR I drafted reports
epel-9.override-extend = EPEL-9N
which means all EL9 builds submitted as BROs will also be tagged in EL9N override tag.

One nitpick I forgot to mention is that those BROs will only be listed in Bodhi under their main release (i.e. EL9 BRO which is also tagged as EL9N override will not be listed when searching for EL9N BROs).

@nirik
Copy link
Member

nirik commented Dec 6, 2023

Yeah, understand. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants