diff --git a/http/management/src/test/java/io/quarkus/qe/OpenShiftExtensionIT.java b/http/management/src/test/java/io/quarkus/qe/extension/OpenShiftBaseDeploymentIT.java similarity index 62% rename from http/management/src/test/java/io/quarkus/qe/OpenShiftExtensionIT.java rename to http/management/src/test/java/io/quarkus/qe/extension/OpenShiftBaseDeploymentIT.java index 105307a6cf..fd1c9c4ddc 100644 --- a/http/management/src/test/java/io/quarkus/qe/OpenShiftExtensionIT.java +++ b/http/management/src/test/java/io/quarkus/qe/extension/OpenShiftBaseDeploymentIT.java @@ -1,20 +1,15 @@ -package io.quarkus.qe; +package io.quarkus.qe.extension; import static org.junit.jupiter.api.Assertions.assertEquals; import org.apache.http.HttpStatus; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import io.quarkus.test.bootstrap.RestService; -import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy; -import io.quarkus.test.scenarios.OpenShiftScenario; import io.quarkus.test.services.QuarkusApplication; import io.restassured.response.Response; -@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension) -@Disabled("Requires fixing https://github.com/quarkusio/quarkus/issues/32135 and changes in the Framework") -public class OpenShiftExtensionIT { +public abstract class OpenShiftBaseDeploymentIT { @QuarkusApplication static final RestService app = new RestService(); diff --git a/http/management/src/test/java/io/quarkus/qe/extension/OpenShiftDockerBuildIT.java b/http/management/src/test/java/io/quarkus/qe/extension/OpenShiftDockerBuildIT.java new file mode 100644 index 0000000000..d06b790f05 --- /dev/null +++ b/http/management/src/test/java/io/quarkus/qe/extension/OpenShiftDockerBuildIT.java @@ -0,0 +1,8 @@ +package io.quarkus.qe.extension; + +import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy; +import io.quarkus.test.scenarios.OpenShiftScenario; + +@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtensionAndDockerBuildStrategy) +public class OpenShiftDockerBuildIT extends OpenShiftBaseDeploymentIT { +} diff --git a/http/management/src/test/java/io/quarkus/qe/extension/OpenShiftExtensionIT.java b/http/management/src/test/java/io/quarkus/qe/extension/OpenShiftExtensionIT.java new file mode 100644 index 0000000000..7aa9e9577e --- /dev/null +++ b/http/management/src/test/java/io/quarkus/qe/extension/OpenShiftExtensionIT.java @@ -0,0 +1,8 @@ +package io.quarkus.qe.extension; + +import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy; +import io.quarkus.test.scenarios.OpenShiftScenario; + +@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingOpenShiftExtension) +public class OpenShiftExtensionIT extends OpenShiftBaseDeploymentIT { +} diff --git a/http/management/src/test/java/io/quarkus/qe/extension/OpenShiftRegistryIT.java b/http/management/src/test/java/io/quarkus/qe/extension/OpenShiftRegistryIT.java new file mode 100644 index 0000000000..f8cb36e2e0 --- /dev/null +++ b/http/management/src/test/java/io/quarkus/qe/extension/OpenShiftRegistryIT.java @@ -0,0 +1,8 @@ +package io.quarkus.qe.extension; + +import io.quarkus.test.scenarios.OpenShiftDeploymentStrategy; +import io.quarkus.test.scenarios.OpenShiftScenario; + +@OpenShiftScenario(deployment = OpenShiftDeploymentStrategy.UsingContainerRegistry) +public class OpenShiftRegistryIT extends OpenShiftBaseDeploymentIT { +} diff --git a/monitoring/micrometer-prometheus/src/test/java/io/quarkus/ts/micrometer/prometheus/OpenShiftCustomMetricsIT.java b/monitoring/micrometer-prometheus/src/test/java/io/quarkus/ts/micrometer/prometheus/OpenShiftCustomMetricsIT.java index fb95c6797c..67467c28aa 100644 --- a/monitoring/micrometer-prometheus/src/test/java/io/quarkus/ts/micrometer/prometheus/OpenShiftCustomMetricsIT.java +++ b/monitoring/micrometer-prometheus/src/test/java/io/quarkus/ts/micrometer/prometheus/OpenShiftCustomMetricsIT.java @@ -51,13 +51,11 @@ public class OpenShiftCustomMetricsIT { @QuarkusApplication static RestService app = new RestService() /* - * TODO fix deployment with OpenShiftDeploymentStrategies in the Framework - * see https://github.com/quarkusio/quarkus/issues/32135#issuecomment-1486740862 for details - * .withProperty("quarkus.management.ssl.certificate.key-store-file", - * "META-INF/resources/server.keystore") + * TODO use https when https://github.com/quarkusio/quarkus/issues/32225 is fixed + * .withProperty("quarkus.management.ssl.certificate.key-store-file", "META-INF/resources/server.keystore") * .withProperty("quarkus.management.ssl.certificate.key-store-password", "password") - * .withProperty("quarkus.management.enabled", "true") */ + .withProperty("quarkus.management.enabled", "true") .onPostStart(OpenShiftCustomMetricsIT::loadServiceMonitor); @Inject diff --git a/monitoring/micrometer-prometheus/src/test/resources/service-monitor.yaml b/monitoring/micrometer-prometheus/src/test/resources/service-monitor.yaml index 8edd20cb5b..e0ab9edba5 100644 --- a/monitoring/micrometer-prometheus/src/test/resources/service-monitor.yaml +++ b/monitoring/micrometer-prometheus/src/test/resources/service-monitor.yaml @@ -7,10 +7,10 @@ metadata: spec: endpoints: - interval: 30s - targetPort: 8080 + targetPort: 9000 path: /q/metrics scheme: http selector: matchLabels: # Configured in application.properties: quarkus.openshift.labels.app-with-metrics - app-with-metrics: 'quarkus-app' \ No newline at end of file + app-with-metrics: 'quarkus-app' diff --git a/pom.xml b/pom.xml index d5220028e3..517d0c570b 100644 --- a/pom.xml +++ b/pom.xml @@ -19,7 +19,7 @@ quarkus-bom io.quarkus 999-SNAPSHOT - 1.3.0.Beta11 + 1.3.0.Beta13 0.42.0 2.12.1.Final 4.5.14