Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add localization: Argument to the pivta() function #2

Open
ragapack opened this issue Aug 22, 2021 · 2 comments
Open

Add localization: Argument to the pivta() function #2

ragapack opened this issue Aug 22, 2021 · 2 comments

Comments

@ragapack
Copy link

Hi,
Very nice tool for my Shiny apps, as I need the Portuguese Language support I want to ask you for the possibility to add this argument to the pivta() function.
localization = "https://cdn.webdatarocks.com/loc/xx.json"
Thank you
Thomas

@feddelegrand7
Copy link
Owner

Hi, @ragapack very sorry for the late answer I just saw the issue. Unfortunately, I'm a bit tight on time at the moment, I'll try to do it asap but in the meantime if you want feel free to submit a PR.

Sorry again.
Best.
Fodil

@ragapack
Copy link
Author

Hi Fodil,
Thank you for your answer, I made a fork and solved in part the localization.
https://github.com/ragapack/pivta
If I open file with the the added local argument it works fine.
pivta(dsource = "https://gist.githubusercontent.com/feddelegrand7/b366864aabf9653361f461cbf972d97c/raw/a62c4672f2f5824b2634a66c948e6258d7c65323/mpg.csv", local = "https://raw.githubusercontent.com/WebDataRocks/pivot-localizations/master/pr.json", sep = ",")
But if after this open an other file using the the menu it goes back to the English localisation.
There is a global object I found in the Documentation but I belive my code in the fork is wrong.
If you have time please have a look.
Thank you
Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants