Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the way of display suggestions moves #624

Merged
merged 2 commits into from
Oct 12, 2019

Conversation

yzyray
Copy link
Contributor

@yzyray yzyray commented Oct 2, 2019

I think it is not necessary to scan every coordinates on board,and there's some formatte differences,i dont know how to make it same.

@featurecat
Copy link
Owner

featurecat commented Oct 2, 2019

This is a good idea and will help improve rendering speed, but it has a small issue. Now, the shadows that are casted by move suggestions are cast on top of existing suggestions. You should probably do two passes: one to draw all the shadows, and one to draw all of the suggestions. It will make them look better.

You can see this if you have two suggestions that are next to each other. One will cast a shadow on top of the other.

@yzyray
Copy link
Contributor Author

yzyray commented Oct 4, 2019

This is a good idea and will help improve rendering speed, but it has a small issue. Now, the shadows that are casted by move suggestions are cast on top of existing suggestions. You should probably do two passes: one to draw all the shadows, and one to draw all of the suggestions. It will make them look better.

You can see this if you have two suggestions that are next to each other. One will cast a shadow on top of the other.

Yes,there is a shadow on top of the other, and i separate drawLeelazSuggestionsBackground into two parts shadow and circle.Now it seems the same effects as before.

@zsalch zsalch merged commit 65660c9 into featurecat:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants