Changing komi should cause Lizzie to regenerate analysis

[lightvector]

If you do the following:

• Play through an SGF with Lizzie interactively, causing many moves to get thousands of playouts establishing the winrate.
• Turn off pondering
• Change the komi (Game -> Set gameInfo)
• Go back to the start of the SGF
• Resume pondering
• Scroll forward through the SGF to try to analyze with the new komi.

Many of the moves will display prominently incorrect winrates and/or scores, until many seconds or minutes pass on a move so that the bot's search with the new komi finally exceeds the total playouts of the search of the old komi. It is possible to manually clear a move one by one (Analyze -> Clear analysis) but it seems that Lizzie should know that the komi has changed and do this automatically.

Of course, possibly users would be sad if the entire analysis was lost when changing komi and changing it back. If so, one might imagine that alternatively Lizzie only clears the analysis when actually repondering a position after komi is changed instead of clearing all analysis in the SGF immediately when komi is changed. Or perhaps changing komi doesn't clear the analysis at all, instead Lizzie remembers and saves for each move a mapping from komi -> analysis, and only displays the analysis for a particular komi when the gameInfo matches that komi. Or any similar such solution.

Thanks!

[featurecat]

@zsalch could you take a look?

[wonsiks]

@lightvector Try change show-bestmoves-by-hold parameter into false in config file.

[zsalch]

Yes, please try the option by @wonsiks .
And I will try to clear by Lizzie when the komi is changed.

[featurecat]

(and engine change). We are thinking that perhaps the move history can store individual stats for each komi/engine.

[featurecat]

to make this process slightly easier I added a shortcut in 62d9266 ctrl+A which means you don't have to go through the menu for each move. Due to the poor code structure I haven't been able to figure out how to change analysis on engine/komi change yet. I'll leave that to zsalch.

[lightvector]

Disabling show-bestmoves-by-hold when komi is changing to disable the feature entirely is an okay workaround. But eagerly await the more selective change within Lizzie itself to handle komi change intelligently and maybe have per-komi or per-engine stats. :)

[lightvector]

And a hotkey to clear analysis is great, thanks.

[zsalch]

@lightvector
I have created a new PR #658. You can try it and let me know if have any questions.