Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About display comment of sgf and read/write sgf with variation & Winrate. #350

Closed
zsalch opened this issue Aug 22, 2018 · 7 comments
Closed

Comments

@zsalch
Copy link
Contributor

zsalch commented Aug 22, 2018

First of all, I am very grateful for the amazing program.

It has helped me a lot.

However, I hope that can see the comments of the sgf when review the game, and I also hope to save the variation and Winrate.

I guess the author must be very busy, I can't wait and to try to make some minor changes.

  1. Add the display the comment of the sgf (C tag): Forgive me very lazy, directly displayed under the variation panel, please ignore the ugly style :(
  2. Add the ability to read and write the sgf with variation
  3. By the way, write the Winrate in the comment of sgf for each step (C tag): Just a little try

Attached the codes and files, the code base on the release 0.5, and use the class (WrapString) of the Jim Menard. Thanks Jim Menard.
There are not many changes, not list the differences.

Just a reference for those in need.

Sorry for use the Issue because I can't find the author E-mail.
If not suitable, please remove it.

Looking forward to related functions of next release.

Thanks again.

@featurecat
Copy link
Owner

Hi

I am happy to introduce changes like these. Please make a pull request (on the Next) branch. it becomes easy to merge and review changes. I will merge when you do that (or I might request some changes if I see potential bugs)

Thanks for your contribution

@zsalch
Copy link
Contributor Author

zsalch commented Aug 22, 2018

Thanks for your reply.
I got it and will to try.
Screen attach failed.
screen

@featurecat
Copy link
Owner

uh oh that screenshot looks like Leela Zero assumed the next move has already been played. bug

@featurecat
Copy link
Owner

the comment space on the right looks good though

@zsalch
Copy link
Contributor Author

zsalch commented Aug 22, 2018

When open the sgf with the variation, the Winrate looks wrongs.
Switch branch between the variations, the Winrate looks normal:
image
May be miss some things when load the variation?

@zsalch
Copy link
Contributor Author

zsalch commented Aug 22, 2018

Create pull request later

@zsalch
Copy link
Contributor Author

zsalch commented Aug 24, 2018

new update:
fix the Winrate wrong when load the sgf with variation. #352

uh oh that screenshot looks like Leela Zero assumed the next move has already been played. bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants