From d2b1967ae22cccb5357312b7ad7a150afb10a0ae Mon Sep 17 00:00:00 2001
From: David Luecke <daff@neyeon.com>
Date: Sat, 9 Feb 2019 11:51:46 -0800
Subject: [PATCH] fix: Update adapter tests to not rely on error instance

---
 packages/adapter-tests/lib/methods.js | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/packages/adapter-tests/lib/methods.js b/packages/adapter-tests/lib/methods.js
index 1a8431d21a..ca32e388d5 100644
--- a/packages/adapter-tests/lib/methods.js
+++ b/packages/adapter-tests/lib/methods.js
@@ -48,7 +48,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           });
           throw new Error('Should never get here');
         } catch (error) {
-          assert.ok(error instanceof errors.NotFound,
+          assert.strictEqual(error.name, 'NotFound',
             'Got a NotFound Feathers error'
           );
         }
@@ -59,7 +59,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           await service.get('568225fbfe21222432e836ff');
           throw new Error('Should never get here');
         } catch (error) {
-          assert.ok(error instanceof errors.NotFound,
+          assert.strictEqual(error.name, 'NotFound',
             'Error is a NotFound Feathers error'
           );
         }
@@ -77,7 +77,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           });
           throw new Error('Should never get here');
         } catch (error) {
-          assert.ok(error instanceof errors.NotFound,
+          assert.strictEqual(error.name, 'NotFound',
             'Got a NotFound Feathers error'
           );
         }
@@ -118,7 +118,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           });
           throw new Error('Should never get here');
         } catch (error) {
-          assert.ok(error instanceof errors.NotFound,
+          assert.strictEqual(error.name, 'NotFound',
             'Got a NotFound Feathers error'
           );
         }
@@ -167,7 +167,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           });
           throw new Error('Should never get here');
         } catch (error) {
-          assert.ok(error instanceof errors.NotFound,
+          assert.strictEqual(error.name, 'NotFound',
             'Got a NotFound Feathers error'
           );
         }
@@ -217,7 +217,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           });
           throw new Error('Should never get here');
         } catch (error) {
-          assert.ok(error instanceof errors.NotFound,
+          assert.strictEqual(error.name, 'NotFound',
             'Got a NotFound Feathers error'
           );
         }
@@ -228,7 +228,9 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           await service.update('568225fbfe21222432e836ff', { name: 'NotFound' });
           throw new Error('Should never get here');
         } catch (error) {
-          assert.ok(error instanceof errors.NotFound, 'Error is a NotFound Feathers error');
+          assert.strictEqual(error.name, 'NotFound',
+            'Error is a NotFound Feathers error'
+          );
         }
       });
 
@@ -247,7 +249,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           });
           throw new Error('Should never get here');
         } catch (error) {
-          assert.ok(error instanceof errors.NotFound,
+          assert.strictEqual(error.name, 'NotFound',
             'Got a NotFound Feathers error'
           );
         }
@@ -293,7 +295,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           });
           throw new Error('Should never get here');
         } catch (error) {
-          assert.ok(error instanceof errors.NotFound,
+          assert.strictEqual(error.name, 'NotFound',
             'Got a NotFound Feathers error'
           );
         }
@@ -370,7 +372,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           await service.patch('568225fbfe21222432e836ff', { name: 'PatchDoug' });
           throw new Error('Should never get here');
         } catch (error) {
-          assert.ok(error instanceof errors.NotFound,
+          assert.strictEqual(error.name, 'NotFound',
             'Error is a NotFound Feathers error'
           );
         }
@@ -390,7 +392,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           });
           throw new Error('Should never get here');
         } catch (error) {
-          assert.ok(error instanceof errors.NotFound,
+          assert.strictEqual(error.name, 'NotFound',
             'Got a NotFound Feathers error'
           );
         }