Feature/typescript fix #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TypeScript 2.5.2 in strict mode throws many errors on the built-in
index.d.tsdeclarations. It doesn't seem possible to prevent TypeScript from throwing these errors (theexcludeoption doesn't work). I feel it's bad form to "ignore" errors, so I'd rather seem them patched in the upstream source.This is one of three patches that fixes these errors. I will be submitting a pull request for feathers-authentication and feathers-hooks shortly.
Other Information
I also have some limited declarations for:
I can provide pull requests for each of those if desired, though I don't promise that most of them are complete, just that they enable basic functionality.