fix(generators): use export type vs export
#3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change one instance of `export { NextFunction }` to
'export type { NextFunction} in `src/app/templates/declarations.tpl.ts`
in the ap generator template.
With the original setup typescript can throw the following error:
`Re-exporting a type when 'isolatedModules' is enabled requires using
'export type'.ts(1205)`
Change the authentication generator template to handle both options
when looking for where to insert new lines.
If someone changes their `declarations.ts` file to have the typescript
required `export type { NextFunction }` then running the command
`feathers generate authentication` will fail looking for `export { NextFunction }`
|
I believe this should work and I'm not entirely sure why the tests are failing. Could you merge with latest and see if that works? |
|
@daffl Yeah I was a bit confused as well, the error from the tests was rather cryptic. I merged the latest and it seems to be passing now. |
daffl
approved these changes
Nov 8, 2023
|
Thank you! Will go out with the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change
export { NextFunction }toexport type { NextFunction }and change authentication generator to look for either version when inserting new code.Tell us about the problem your pull request is solving.
I get the following error in
src/declarations.tson the line withexport { NextFunction }:Re-exporting a type when 'isolatedModules' is enabled requires using 'export type'.ts(1205).If that suggestion is followed, then running
feathers generate authenticationfails since it is looking for the lineexport { NextFunction }to insert new code after/before.Are there any open issues that are related to this?
Not that I can find
Is this PR dependent on PRs in other repos?
No