Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make app.configure async aware #1965

Closed
AuHau opened this issue May 21, 2020 · 2 comments
Closed

Make app.configure async aware #1965

AuHau opened this issue May 21, 2020 · 2 comments

Comments

@AuHau
Copy link

AuHau commented May 21, 2020

I am not completely sure, but I believe that app.configure() is Feather's addition to Express right? On Express's side, the app.configure was removed since version 4.x which I believe you are using latest version for the @feathers/express package right?

If that is the case I would like to suggest to make the app.configure() async aware. Preferably if Promise is returned by the callback await until its resolution.

This is important when you want to configure your application from async sources (for example populate some data-stores from database etc.). This would for example "fixed" the need for storing Promise on app when syncing database for Sequelize like app.set('sequelizeSync', sequelize.sync()).

This I believe should not be a breaking change. Would that be something you would be willing to accept? If so, I could provide PR for this functionality.

@daffl
Copy link
Member

daffl commented May 21, 2020

Asynchronous setup and configuration is slated for the next version. The original issue is #509

@AuHau
Copy link
Author

AuHau commented May 22, 2020

That is pretty dope! Thanks for the info!
Looking forward to the new release :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants