Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for undefined access token #1571

Merged
merged 1 commit into from
Sep 21, 2019

Conversation

keywordnew
Copy link
Contributor

Summary

  • Tell us about the problem your pull request is solving.

This PR adds a check for if the access token is undefined.

  • Are there any open issues that are related to this?

Fixes #1568.

  • Is this PR dependent on PRs in other repos?

Nope, AFAIK.

Other Information

This fix does not yet have a test.

@daffl daffl merged commit 976369d into feathersjs:master Sep 21, 2019
@daffl
Copy link
Member

daffl commented Sep 21, 2019

Awesome! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feathers auth assumes an accessToken exists for socket (regression)
2 participants