[feature request] Accept a express instance as optional parameter in the feathersExpress.

[TobyMosque]

Accept a express instance as optional parameter in the feathersExpress.

Current

// link: https://github.com/feathersjs/feathers/blob/master/packages/express/lib/index.js
// imports
function feathersExpress (feathersApp) {
  if (!feathersApp) {
    return express();
  }

  if (typeof feathersApp.setup !== 'function') {
    throw new Error('@feathersjs/express requires a valid Feathers application instance');
  }

  if (!feathersApp.version || feathersApp.version < '3.0.0') {
    throw new Error(`@feathersjs/express requires an instance of a Feathers application version 3.x or later (got ${feathersApp.version || 'unknown'})`);
  }

  const expressApp = express();
  // do something
}

Proposed

// imports
function feathersExpress (feathersApp, expressApp) {
  if (!feathersApp) {
    return expressApp || express();
  }

  if (typeof feathersApp.setup !== 'function') {
    throw new Error('@feathersjs/express requires a valid Feathers application instance');
  }

  if (!feathersApp.version || feathersApp.version < '3.0.0') {
    throw new Error(`@feathersjs/express requires an instance of a Feathers application version 3.x or later (got ${feathersApp.version || 'unknown'})`);
  }

  expressApp = expressApp || express();
  // do something
}

[MichaelJCole]

Hi @daffl this is part of the Quasar + Feathers conversation with @nothingismagick. @TobyMosque is on the team and this change is toward integrating the dev experience.

[daffl]

Sounds good. I'll try and put up a PR for this today.

[daffl]

Released in v4.0.0-pre.5