fix: Do not inherit app object from Object prototype #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertho-zero
reviewed
Jan 3, 2019
|
|
||
| function createApplication () { | ||
| const app = {}; | ||
| const app = Object.create(baseObject); |
There was a problem hiding this comment.
That would not be enough to do that?
const app = Object.create(null);There was a problem hiding this comment.
I thought so, too but Uberproto tries to get the Prototype when mixing into the app object, gets null and blows up so I needed to add another one to the chain.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that some browsers (or plugins or something) override the Object prototype, specifically the
initproperty, which we use to call to initialize the application (causing.init is not a functionerrors). The best way to avoid this is to inherit fromnullinstead of the Object prototype.