Skip to content

Commit

Permalink
fix: Improve Params typing (#1474)
Browse files Browse the repository at this point in the history
  • Loading branch information
vonagam authored and daffl committed Jul 20, 2019
1 parent e542cb3 commit 54a3aa7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
3 changes: 3 additions & 0 deletions packages/feathers/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ declare namespace createApplication {
interface Params {
query?: Query;
paginate?: false | Pick<PaginationOptions, 'max'>;
provider?: string;
route?: {[key: string]: string};
headers?: {[key: string]: any};

[key: string]: any; // (JL) not sure if we want this
}
Expand Down
6 changes: 5 additions & 1 deletion packages/transport-commons/src/channels/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Debug from 'debug';
import { compact, flattenDeep, noop } from 'lodash';
import { Channel } from './channel/base';
import { Channel, RealTimeConnection } from './channel/base';
import { CombinedChannel } from './channel/combined';
import { channelMixin, publishMixin, keys, PublishMixin, Event, Publisher } from './mixins';
import { Application, Service } from '@feathersjs/feathers';
Expand Down Expand Up @@ -29,6 +29,10 @@ declare module '@feathersjs/feathers' {
registerPublisher<T> (publisher: Publisher<T>): this;
registerPublisher<T> (event: Event, publisher: Publisher<T>): this;
}

interface Params {
connection?: RealTimeConnection;
}
}

export { keys };
Expand Down

0 comments on commit 54a3aa7

Please sign in to comment.