fix: Update adapter common tests to check for falsy (#1140)

feathersjs · Dec 20, 2018 · 2856722 · 2856722
1 parent ae97020
commit 2856722
Show file tree

Hide file tree

Showing 2 changed files with 223 additions and 7 deletions.
diff --git a/packages/adapter-commons/lib/tests/methods.js b/packages/adapter-commons/lib/tests/methods.js
@@ -38,7 +38,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           `${idProp} id property matches`
         );
         assert.strictEqual(data.name, 'Doug', 'data.name matches');
-        assert.strictEqual(data.age, undefined, 'data.age is undefined');
+        assert.ok(!data.age, 'data.age is falsy');
       });
 
       test('.get + id + query', async () => {
@@ -88,7 +88,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
         });
 
         assert.strictEqual(data.name, 'Doug', 'data.name matches');
-        assert.strictEqual(data.age, undefined, 'data.age is undefined');
+        assert.ok(!data.age, 'data.age is falsy');
       });
 
       test('.remove + id + query', async () => {
@@ -150,7 +150,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
           `${idProp} id matches`
         );
         assert.strictEqual(data.name, 'Dougler', 'data.name matches');
-        assert.strictEqual(data.age, undefined, 'data.age is undefined');
+        assert.ok(!data.age, 'data.age is falsy');
       });
 
       test('.update + $select', async () => {
@@ -165,7 +165,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
         });
 
         assert.strictEqual(data.name, 'Dougler', 'data.name matches');
-        assert.strictEqual(data.age, undefined, 'data.age is undefined');
+        assert.ok(!data.age, 'data.age is falsy');
       });
 
       test('.update + id + query', async () => {
@@ -218,7 +218,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
         });
 
         assert.strictEqual(data.name, 'PatchDoug', 'data.name matches');
-        assert.strictEqual(data.age, undefined, 'data.age is undefined');
+        assert.ok(!data.age, 'data.age is falsy');
       });
 
       test('.patch + id + query', async () => {
@@ -344,7 +344,7 @@ module.exports = (test, app, errors, serviceName, idProp) => {
         });
 
         assert.strictEqual(data.name, 'William', 'data.name matches');
-        assert.strictEqual(data.age, undefined, 'data.age is undefined');
+        assert.ok(!data.age, 'data.age is falsy');
 
         await service.remove(data[idProp]);
       });

diff --git a/packages/adapter-commons/package-lock.json b/packages/adapter-commons/package-lock.json