Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support array namespaces for module nesting #35

Merged
merged 4 commits into from
Aug 18, 2017

Conversation

jskrzypek
Copy link
Contributor

Summary

This PR addresses two issues, #15 and #34, by

  • replacing deep-assign and clone dependencies with lodash.merge and lodash.clonedeep
  • refactoring the namespace resolution utils to support array namespaces and to be more DRY
  • refactoring stripSlashes() in utils to support arrays and use lodash.trim instead of the regex

@marshallswain
Copy link
Member

@jskrzypek this is beautiful. Looks like a minor release? Nothing breaking in here, right?

@jskrzypek
Copy link
Contributor Author

@marshallswain
Nope, I did not change any tests to make them pass. I also changed getNameFromConfig() to be getNameFromExplicit() to better match the nameStyles value, but I updated all of the references to the function, so nothing breaks.

@daffl
Copy link
Member

daffl commented Aug 17, 2017

@marshallswain I can make the release if you add me to npm.

@marshallswain
Copy link
Member

@daffl that would be great. I added you. Thanks!

@daffl daffl merged commit c3687e9 into feathersjs-ecosystem:master Aug 18, 2017
@daffl
Copy link
Member

daffl commented Aug 18, 2017

Released as v0.8.0. Thank you for the PR!

@daffl daffl mentioned this pull request Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants