Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

Error handler usage/setup is mis-documented #96

Closed
2 tasks done
alexisabril opened this issue Jan 2, 2018 · 0 comments
Closed
2 tasks done

Error handler usage/setup is mis-documented #96

alexisabril opened this issue Jan 2, 2018 · 0 comments

Comments

@alexisabril
Copy link

Steps to reproduce

This issue is not a bug in the software, just a documentation issue. feathers-error is still listed in the README along with the Buzzard version: @feathersjs/errors. In the error handler documentation, the prior .configuration() call is used with the handler. This may be a holdover from Express 3.x as the Feathers configuration will invoke the method producing an error.

A fix would be to change the documentation to:

app.configure(errorHandler({

https://gist.github.com/alexisabril/6f02f3ab5742a5252cfd41ff89be14f9

Sample application using error handler as documented in README: https://gist.github.com/alexisabril/6f02f3ab5742a5252cfd41ff89be14f9

  • Tell us what broke. The more detailed the better.
  • If you can, please create a simple example that reproduces the issue and link to a gist, jsbin, repo, etc.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant