Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

Possible issue with Node 4 #51

Closed
eddyystop opened this issue Oct 18, 2016 · 1 comment
Closed

Possible issue with Node 4 #51

eddyystop opened this issue Oct 18, 2016 · 1 comment

Comments

@eddyystop
Copy link

I got the following while running tests for feathers-hooks-common on Node 4.

  3) validate DEPRECATED hooks validateUsingCallback test fails on errors:
     Uncaught ReferenceError: Reflect is not defined
      at BadRequest.ExtendableBuiltin (node_modules/feathers-errors/lib/index.js:21:20)
      at BadRequest.FeathersError (node_modules/feathers-errors/lib/index.js:99:87)
      at new BadRequest (node_modules/feathers-errors/lib/index.js:140:79)
      at cb (lib/common.js:317:64)
      at null._onTimeout (test/validate.test.js:47:15)
  4) validate DEPRECATED hooks validate Promise function test fails on errors:
     Uncaught ReferenceError: Reflect is not defined
      at BadRequest.ExtendableBuiltin (node_modules/feathers-errors/lib/index.js:21:20)
      at BadRequest.FeathersError (node_modules/feathers-errors/lib/index.js:99:87)
      at new BadRequest (node_modules/feathers-errors/lib/index.js:140:79)
      at null._onTimeout (test/validate.test.js:129:26)

Lines 316-318 are

if (res && Object.keys(res).length) {
  throw new errors.BadRequest({ errors: res });
}

I required babel-polyfill and the problem didn't occur.

@eddyystop
Copy link
Author

Feathers core requires babel-polyfill. So there's no problem with feathers-errors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant