Skip to content
This repository has been archived by the owner on Aug 29, 2018. It is now read-only.

Remove Lodash dependency #10

Closed
daffl opened this issue Nov 28, 2015 · 4 comments
Closed

Remove Lodash dependency #10

daffl opened this issue Nov 28, 2015 · 4 comments

Comments

@daffl
Copy link
Member

daffl commented Nov 28, 2015

Currently when installing Feathers you get a warning because of an old Lodash dependency used in feathers-errors. Since it is only used in one place we can probably just remove it.

@ekryski
Copy link
Member

ekryski commented Nov 30, 2015

I can tackle this, this week. I'll probably just convert this guy over to ES6 as well.

@daffl
Copy link
Member Author

daffl commented Nov 30, 2015

Maybe we can put the error types into a separate repo at feathers-error-types. Something I've been wondering is if it is really possible to make a generic error handler or if you'll eventually have to modify it for your app anyway. In the generated app I currently just add one as its own middleware (https://github.com/feathersjs/generator-feathers/blob/app-architecture/app/templates/static/src/middleware/error.js) that just spits out an HTML page or the JSON error that you can then modify as needed.

@ekryski
Copy link
Member

ekryski commented Nov 30, 2015

Ya I've been considering that as well. I'd rather see error types go with core as a dependency and then move this to part of the boilerplate as middleware. That way it's easy for people to customize or get rid of if they want.

@ekryski
Copy link
Member

ekryski commented Nov 30, 2015

Closing in favour of this: #11

@ekryski ekryski closed this as completed Nov 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants