-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta test the pre-release #40
Comments
Thanks, @LinusBorg. I had removed it internally, but it should have been removed from the docs at that time. I've decided to add it back as |
Good solution, that should work! |
So i have been testing this, but only in a small app that's in the early stages, so only 3 services and auth, but so far it works really nice! the new API is really good. |
I just released I would love it if everyone could try it out and provide feedback. |
Works with no hiccups, the new api looks amazing. If you want to try it out with the feathers-vuex app, I have a fork with the neccesary changes feathersjs-ecosystem/feathers-chat-vuex-0.7#46 |
@rayfoss oh hell yes! You saved me a lot of time. Thank you! I'll look it over and get it merged. I'm so glad it's working well. I'm sure the increase in test coverage helped. 😄 |
When we have a paginated service, feathers-vuex currently swallows that information, it's not added to the state. I think it should be, we need some way to get the total after we made a paginated call with |
@LinusBorg, Pagination is a difficult one. I've rethought, fixed, and tested pagination support. Please try it out when you get a chance. It was pretty tricky. You can read more about the implementation here in the readme: https://github.com/feathersjs/feathers-vuex/tree/1.0#querying-with-find--pagination
|
Thanks! Will try this asap. I can understand that this is not very easy, but your solution seems to solve it senisbly. |
Everything is working very nice with the pre.3, but I'm getting an error. If I reset the database and remove all users the feathers-jwt remains on the browser so feathers-vuex tries to use it to log in. With the previous version the auth got an error and couldn't finish, with this last version the login finishes successfully after I call it like this. this.$store.dispatch('auth/authenticate') In feathers backend I get this error
|
@ellipticaldoor I don't see a way around this other than manually deleting the jwt from storage. |
@marshallswain what I did before the pre was catching the authentication error and delete the jwt with this code: async created() {
try {
await this.$store.dispatch('auth/authenticate')
} catch (error) {
if (
error.message.includes('Could not find stored JWT') ||
error.message.includes('_id is missing from current user.')
) {
const token = localStorage.getItem('feathers-jwt')
if (token) {
localStorage.removeItem('feathers-jwt')
document.cookie =
'feathers-jwt=; expires=Thu, 01 Jan 1970 00:00:00 GMT; path=/'
location.reload()
}
} else {
console.error(error)
}
}
}, But now in the pre the error is not catched and also on the vuex store looks like it succesfully logged in: This is how the error looks now: Vuex store: How I can catch it? |
Version 1.x has shipped! |
A Beta version of 1.0.0 is available and published on npm. If you would like to try it out, just do
You can find docs in the
1.0
branch readme.md:https://github.com/feathersjs/feathers-vuex/tree/1.0
The internal API stays almost 100% the same, and only the general usage instructions change. The big breaking changes are
.vuex
method is gone, as is thevuexOptions
object.I would love it if somebody could try this out with Nuxt and let me know how it goes.
The text was updated successfully, but these errors were encountered: