Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All declarations of 'observable' must have identical modifiers. #120

Closed
dottodot opened this issue Jun 22, 2018 · 4 comments
Closed

All declarations of 'observable' must have identical modifiers. #120

dottodot opened this issue Jun 22, 2018 · 4 comments

Comments

@dottodot
Copy link

After updating my angular project to rxjs6.2.1 I started getting the error

ERROR in node_modules/feathers-reactive/node_modules/rxjs/internal/symbol/observable.d.ts(4,5): error TS2687: All declarations of 'observable' must have identical modifiers.

I believe it just needs the dependency updating in feathers-reactive to resolve this.

@j2L4e
Copy link
Collaborator

j2L4e commented Jun 22, 2018

ReactiveX/rxjs#3769

updating package-lock to rxjs 6.2.1 will solve this.

@daffl maybe we should make rxjs a peer dependency (breaking :/) or remove package-lock.json

@daffl
Copy link
Member

daffl commented Jun 23, 2018

The package-lock.json in this repository will not be published and will have no impact on other installations. From the npm docs:

One key detail about package-lock.json is that it cannot be published, and it will be ignored if found in any place other than the toplevel package.

This may be a different issue though.

@dottodot
Copy link
Author

This repository just needs updating to rxjs 6.2.1 as it a know bug that was fixed in that version.

@daffl
Copy link
Member

daffl commented Jun 23, 2018

I don't understand why npm does not install the latest of what is in the dependency range but I'll make a patch release with the updated version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants