Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Feast Operator example with Postgres in TLS mode. #5028

Merged
merged 13 commits into from
Feb 25, 2025
Merged

feat: Feast Operator example with Postgres in TLS mode. #5028

merged 13 commits into from
Feb 25, 2025

Conversation

lokeshrangineni
Copy link
Contributor

@lokeshrangineni lokeshrangineni commented Feb 7, 2025 •
edited
Loading

Feast Operator example with Postgres in TLS mode.

@lokeshrangineni lokeshrangineni changed the title rough working instructions to set up postgres in TLS mode and setting… feat: Feast Operator example with Postgres in TLS mode. Feb 7, 2025
@lokeshrangineni
rough working instructions to set up postgres in TLS mode and setting…
5242d95 
… up the feast using operator.

Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
@lokeshrangineni
adding the example of postgres tls setup and deploying feast using po…
4b75e78 
…stgres tls as well.

Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
@lokeshrangineni lokeshrangineni force-pushed the feature/operator-postgres-ssl-example branch from e89ee80 to 4b75e78 Compare February 17, 2025 05:09
@lokeshrangineni
deleting the files which are not needed.
fe47fd2 
Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
@lokeshrangineni lokeshrangineni marked this pull request as ready for review February 17, 2025 05:12
@lokeshrangineni lokeshrangineni requested a review from a team as a code owner February 17, 2025 05:12
@lokeshrangineni
uncommenting the code to uninstall the feast operator.
806aede 
Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
@lokeshrangineni
Added the postgres example to the examples README.md index.
fadbbf4 
Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
tchughesiv
tchughesiv previously requested changes Feb 17, 2025
View reviewed changes
@redhatHameed
Copy link
Contributor

@tchughesiv @lokeshrangineni can use same directory operator-quickstart and can add new notebook example with Postgres in TLS mode with that all example related with operator will be same place. WDYT ?

@lokeshrangineni
Copy link
Contributor Author

lokeshrangineni commented Feb 17, 2025 •
edited
Loading

@tchughesiv @lokeshrangineni can use same directory operator-quickstart and can add new notebook example with Postgres in TLS mode with that all example related with operator will be same place. WDYT ?

This example is having multiple notebooks isolates the group of steps. It appears to be the same notebooks as operator-quickstart based on the names but the content is different. It is going to be a further different after I add more description about volumeMounts and FEAST_CA_CERT_FILE_PATH. The abstraction i can do more with the demo notebook which is pretty close in both examples. The options i see are 1) combining them into one makes a big notebook with sub sections. 2) may be is it ok to add sub folders under operator-quickstart one with existing and another with postgres with tls.

any further preferences?

@redhatHameed
Copy link
Contributor

@tchughesiv @lokeshrangineni can use same directory operator-quickstart and can add new notebook example with Postgres in TLS mode with that all example related with operator will be same place. WDYT ?

This example is having multiple notebooks isolates the group of steps. It appears to be the same notebooks as operator-quickstart based on the names but the content is different. It is going to be a further different after I add more description about volumeMounts and FEAST_CA_CERT_FILE_PATH. The abstraction i can do more with the demo notebook which is pretty close in both examples. The options i see are 1) combining them into one makes a big notebook with sub sections. 2) may be is it ok to add sub folders under operator-quickstart one with existing and another with postgres with tls.

any further preferences?

if it's not fitting with existing example, then sure you can go with existing approach.

The idea is to create a note for an example like 03-TLS, then patch the CR to update the TLS configuration, and proceed further to verify that TLS is set up correctly and proceed with existing example accordingly. You will definitely need to configure PostgreSQL with TLS installation for that just delete the existing installation and setup it with TLS.

@tchughesiv
Copy link
Contributor

imo, the cleanest way would be to piggy-back off of the existing quickstart. Just add another .ipynb file, make it #3. And then continue what's already been done with the demo from #2. You could certainly create a subdir for the ssl bits.
https://github.com/feast-dev/feast/tree/master/examples/operator-quickstart

@lokeshrangineni
Adding more details related to volumes and volumeMounts. and also inc…
9b47b4b 
…orporating code review comments.

Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
@tchughesiv
Copy link
Contributor

tchughesiv commented Feb 17, 2025 •
edited by lokeshrangineni
Loading

@lokeshrangineni that said, if its a huge ordeal to combine them... i'm completely fine keeping them separate as well

After removing the demo notebook there is not lot of synergy between operator-quickstart. installing postgres and uninstall jupyter notebook are totally different. Installing feast notebook is emphasizing more on the volume support and mounting secrets with different choices. so prefer to keep them separate as we discussed.

@lokeshrangineni
Removed the demo jupyter notebook which is not adding a lot of value.…
f9a24eb 
… Also fixed some broken links.

Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
@lokeshrangineni
Minor fixes.
70e5fb5 
Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
@lokeshrangineni
Minor fixes.
bd990be 
Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
@lokeshrangineni
Minor fixes.
6725e53 
Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
@lokeshrangineni
Minor fixes.
05339cf 
Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
redhatHameed
redhatHameed reviewed Feb 24, 2025
View reviewed changes
@lokeshrangineni
Modified the examples README.md to make it more readable.
2b96077 
1. Now the numbers are automatically ordered when we render to avoid renumbering when we add an example in between.
2. Added separate section for the feast go operator examples.

Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
tchughesiv
tchughesiv reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@tchughesiv tchughesiv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lokeshrangineni to ensure this demo continues to work, you may want to specify a version of the bitnami/postgresql helm chart during install. future changes/release could derail this example.

@lokeshrangineni
Adding the helm chart version to ensure it also works in the future.
704f098 
Signed-off-by: lrangine <19699092+lokeshrangineni@users.noreply.github.com>
@lokeshrangineni
Copy link
Contributor Author

@lokeshrangineni to ensure this demo continues to work, you may want to specify a version of the bitnami/postgresql helm chart during install. future changes/release could derail this example.

I have incorporated in the commit

@redhatHameed
Copy link
Contributor

@lokeshrangineni WDYT Squashing commits to single ?

@tchughesiv
Copy link
Contributor

@redhatHameed @lokeshrangineni no need to squash them... the merge will

@redhatHameed redhatHameed enabled auto-merge (squash) February 25, 2025 16:27
@lokeshrangineni lokeshrangineni dismissed tchughesiv’s stale review February 25, 2025 17:50

already incorporated or responded to the request.

@redhatHameed redhatHameed merged commit 2c46f6a into feast-dev:master Feb 25, 2025
24 checks passed
lokeshrangineni added a commit that referenced this pull request Feb 25, 2025
@lokeshrangineni
Revert "feat: Feast Operator example with Postgres in TLS mode. (#5028)"
f41a1a5 
This reverts commit 2c46f6a.
franciscojavierarceo pushed a commit that referenced this pull request Mar 10, 2025
@feast-ci-bot
chore(release): release 0.47.0
3e3afa9 
# [0.47.0](v0.46.0...v0.47.0) (2025-03-10)

* feat!: Include PUBLIC_URL in defaultProjectListPromise URL in /ui ([2f0f7b3](2f0f7b3))

### Bug Fixes

* Add transformation_service_endpoit to support Go feature server. ([#5071](#5071)) ([5627d7c](5627d7c))
* Adding extra space on the VM to kind cluster to see if this solves the issue with memory not available with operator e2e tests. ([#5102](#5102)) ([e6e928c](e6e928c))
* Allow unencrypted Snowflake key ([#5097](#5097)) ([87a7c23](87a7c23))
* Cant add different type of list types ([#5118](#5118)) ([bebd7be](bebd7be))
* Fixing transformations on writes ([#5127](#5127)) ([95ac34a](95ac34a))
* Identify s3/remote uri path correctly ([#5076](#5076)) ([93becff](93becff))
* Increase available action VM storage and reduce dev feature-server image size ([#5112](#5112)) ([75f5a90](75f5a90))
* Move Feast to pyproject.toml instead of setup.py ([#5067](#5067)) ([4231274](4231274))
* Skip refresh if already in progress or if lock is already held ([#5068](#5068)) ([f3a24de](f3a24de))

### Features

* Add an OOTB Chat uI to the Feature Server to support RAG demo ([#5106](#5106)) ([40ea7a9](40ea7a9))
* Add Couchbase Columnar as an Offline Store ([#5025](#5025)) ([4373cbf](4373cbf))
* Add Feast Operator RBAC example with Kubernetes Authentication … ([#5077](#5077)) ([2179fbe](2179fbe))
* Added docling and pytorch as add on ([#5089](#5089)) ([135342b](135342b))
* Feast Operator example with Postgres in TLS mode. ([#5028](#5028)) ([2c46f6a](2c46f6a))
* Operator - Add feastProjectDir section to CR with git & init options ([#5079](#5079)) ([d64f01e](d64f01e))
* Override the udf name when provided as input to an on demand transformation ([#5094](#5094)) ([8a714bb](8a714bb))
* Set value_type of entity directly in from_proto ([#5092](#5092)) ([90e7498](90e7498))
* Updating retrieve online documents v2 to work for other fields for sq… ([#5082](#5082)) ([fc121c3](fc121c3))

### BREAKING CHANGES

* The PUBLIC_URL environment variable is now taken into account by default
when fetching the projects list. This is a breaking change only if all
these points apply:

1. You're using Feast UI as a module

2. You're serving the UI files from a non-root path via the PUBLIC_URL
   environment variable

3. You're serving the project list from the root path

4. You're not passing the `feastUIConfigs.projectListPromise` prop to
   the FeastUI component

In this case, you need to explicitly fetch the project list from the
root path via the `feastUIConfigs.projectListPromise` prop:

```diff
 const root = createRoot(document.getElementById("root")!);
 root.render(
   <React.StrictMode>
-    <FeastUI />
+    <FeastUI
+      feastUIConfigs={{
+        projectListPromise: fetch("/projects-list.json", {
+            headers: {
+              "Content-Type": "application/json",
+            },
+          }).then((res) => res.json())
+      }}
+    />
   </React.StrictMode>
 );
```

Signed-off-by: Harri Lehtola <peruukki@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redhatHameed redhatHameed redhatHameed approved these changes

@tchughesiv tchughesiv Awaiting requested review from tchughesiv

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lokeshrangineni @redhatHameed @tchughesiv