Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the behavior of install-python-ci-dependencies #4000

Closed
shuchu opened this issue Mar 9, 2024 · 0 comments · Fixed by #4004
Closed

Update the behavior of install-python-ci-dependencies #4000

shuchu opened this issue Mar 9, 2024 · 0 comments · Fixed by #4004

Comments

@shuchu
Copy link
Collaborator

shuchu commented Mar 9, 2024

Expected Behavior

There's a very confusing and probably unnecessary python setup.py develop call in install-python-ci-dependencies make command that's causing this error. It should just be a call to only build protos instead

Current Behavior

install-python-ci-dependencies:
python -m piptools sync sdk/python/requirements/py$(PYTHON)-ci-requirements.txt
COMPILE_GO=true python setup.py develop

Steps to reproduce

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution

install-python-ci-dependencies:
python -m piptools sync sdk/python/requirements/py$(PYTHON)-ci-requirements.txt
pip install --no-deps -e .
python setup.py build_python_protos --inplace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant