Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't /push (inferred) integers to a float feature #3884

Closed
robhowley opened this issue Jan 12, 2024 · 0 comments · Fixed by #3874
Closed

can't /push (inferred) integers to a float feature #3884

robhowley opened this issue Jan 12, 2024 · 0 comments · Fixed by #3874

Comments

@robhowley
Copy link
Contributor

Expected Behavior

Attempts to /push the following data

{
  "df": {
    "feature_one": [123, 456]
  }
}

to the online store where the feature view field is Field("feature_one", dtype=types.Float64) should succeed.

Current Behavior

This fails with the following error.

image

Possible Solution

The PYTHON_SCALAR_VALUE_TYPE_TO_PROTO_VALUE map defined here states that value types of FLOAT have to be inferred as either np.float or float. Add int and np.int_ to the list and it works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant