Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnowflakeOfflineStoreConfig import fails in the python feature server #2560

Closed
jerive opened this issue Apr 17, 2022 · 2 comments · Fixed by #2565
Closed

SnowflakeOfflineStoreConfig import fails in the python feature server #2560

jerive opened this issue Apr 17, 2022 · 2 comments · Fixed by #2565

Comments

@jerive
Copy link
Contributor

jerive commented Apr 17, 2022

Expected Behavior

Configuring snowflake does not make the AWS python server fail

Current Behavior

[ERROR] FeastModuleImportError: Could not import module 'feast.infra.offline_stores.snowflake' 
while attempting to load class 'SnowflakeOfflineStoreConfig'

Steps to reproduce

  • Configure a snowflake offline store
  • Deploy the AWS python feature server
  • Query /get-online-features

Specifications

  • Version: v0.20.0
  • Platform:
  • Subsystem: Python feature server AWS

Possible Solution

@achals
Copy link
Member

achals commented Apr 18, 2022

Hi @jerive , you're right that this is indeed a bug. We're planning on fixing this in a patch release soon (hopefully this week)

@achals
Copy link
Member

achals commented Apr 18, 2022

More context: The AWS Feature Server dockerfile doesn't install the snowflake extra, and feast by design eagerly loads the offline store.

Ideally, we should instantiate the offline store lazily so that we don't load it in environments like feature serving, where it's not neeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants