Skip to content

Commit fd255ca

Browse files
authored
Enable the types test to run on all compatible environments (#1840)
* Adding fixtures for type test Signed-off-by: Danny Chiao <danny@tecton.ai> * Refactor to use fixtures Signed-off-by: Danny Chiao <danny@tecton.ai> * Add issue on github Signed-off-by: Danny Chiao <danny@tecton.ai>
1 parent f829232 commit fd255ca

File tree

4 files changed

+216
-177
lines changed

4 files changed

+216
-177
lines changed

sdk/python/feast/infra/online_stores/sqlite.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,10 @@ def teardown(
192192
tables: Sequence[Union[FeatureTable, FeatureView]],
193193
entities: Sequence[Entity],
194194
):
195-
os.unlink(self._get_db_path(config))
195+
try:
196+
os.unlink(self._get_db_path(config))
197+
except FileNotFoundError:
198+
pass
196199

197200

198201
def _table_id(project: str, table: Union[FeatureTable, FeatureView]) -> str:

sdk/python/tests/conftest.py

-6
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,3 @@ def e2e_data_sources(environment: Environment):
132132
yield df, data_source
133133

134134
environment.data_source_creator.teardown()
135-
136-
137-
@pytest.fixture(params=FULL_REPO_CONFIGS, scope="session")
138-
def type_test_environment(request):
139-
with construct_test_environment(request.param) as e:
140-
yield e

sdk/python/tests/integration/feature_repos/universal/data_sources/bigquery.py

+1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ def teardown(self):
4242
self.dataset_id, delete_contents=True, not_found_ok=True
4343
)
4444
print(f"Deleted dataset '{self.dataset_id}'")
45+
self.dataset = None
4546

4647
def create_offline_store_config(self):
4748
return BigQueryOfflineStoreConfig()

0 commit comments

Comments
 (0)