Skip to content

Commit c2a6c6c

Browse files
authored
fix: Update github workflow to prevent redis from overlapping ports. (#2350)
* Update redis port Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Add comment detailing why 12345 is port selected Signed-off-by: Kevin Zhang <kzhang@tecton.ai> * Keep redis at 6379 for now until we can test against new github workflow Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
1 parent 251eee4 commit c2a6c6c

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

.github/workflows/pr_integration_tests.yml

+5
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,11 @@ jobs:
102102
# code from the PR.
103103
ref: refs/pull/${{ github.event.pull_request.number }}/merge
104104
submodules: recursive
105+
- name: Start Redis
106+
uses: supercharge/redis-github-action@1.4.0
107+
with:
108+
redis-version: ${{ matrix.redis-version }}
109+
redis-port: 12345
105110
- name: Setup Python
106111
uses: actions/setup-python@v2
107112
id: setup-python

sdk/python/tests/integration/feature_repos/repo_configuration.py

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
)
4747

4848
DYNAMO_CONFIG = {"type": "dynamodb", "region": "us-west-2"}
49+
# Port 12345 will chosen as default for redis node configuration because Redis Cluster is started off of nodes 6379 -> 6384. This causes conflicts in cli integration tests so we manually keep them separate.
4950
REDIS_CONFIG = {"type": "redis", "connection_string": "localhost:6379,db=0"}
5051
REDIS_CLUSTER_CONFIG = {
5152
"type": "redis",

0 commit comments

Comments
 (0)