feat: Allow all snowflake python connector connection methods to be available to Feast (#2356)

* Allow all snowflake python connector connection methods to be available to feast

Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>

* format/lint

Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>

* feat: have feast using snowflake python connector for authentication

Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>

* fix random print

Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>

Author: sfc-gh-madkins

sdk/python/feast/entity.py

@@ -11,7 +11,6 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-import warnings
 from datetime import datetime
 from typing import Dict, Optional
 
@@ -45,7 +44,7 @@ class Entity:
     value_type: ValueType
     join_key: str
     description: str
-    tags: Dict[str, str]
+    labels: Dict[str, str]
     owner: str
     created_timestamp: Optional[datetime]
     last_updated_timestamp: Optional[datetime]
@@ -65,17 +64,10 @@ def __init__(
         self.join_key = join_key if join_key else name
         self.description = description
 
-        if labels is not None:
-            self.tags = labels
-            warnings.warn(
-                (
-                    "The parameter 'labels' is being deprecated. Please use 'tags' instead. "
-                    "Feast 0.20 and onwards will not support the parameter 'labels'."
-                ),
-                DeprecationWarning,
-            )
+        if labels is None:
+            self.labels = dict()
         else:
-            self.tags = labels or tags or {}
+            self.labels = labels
 
         self.created_timestamp = None
         self.last_updated_timestamp = None
@@ -163,9 +155,9 @@ def from_proto(cls, entity_proto: EntityV2Proto):
         )
 
         if entity_proto.meta.HasField("created_timestamp"):
-            entity._created_timestamp = entity_proto.meta.created_timestamp.ToDatetime()
+            entity.created_timestamp = entity_proto.meta.created_timestamp.ToDatetime()
         if entity_proto.meta.HasField("last_updated_timestamp"):
-            entity._last_updated_timestamp = (
+            entity.last_updated_timestamp = (
                 entity_proto.meta.last_updated_timestamp.ToDatetime()
             )
 
@@ -179,10 +171,10 @@ def to_proto(self) -> EntityV2Proto:
             An EntityV2Proto protobuf.
         """
         meta = EntityMetaProto()
-        if self._created_timestamp:
-            meta.created_timestamp.FromDatetime(self._created_timestamp)
-        if self._last_updated_timestamp:
-            meta.last_updated_timestamp.FromDatetime(self._last_updated_timestamp)
+        if self.created_timestamp:
+            meta.created_timestamp.FromDatetime(self.created_timestamp)
+        if self.last_updated_timestamp:
+            meta.last_updated_timestamp.FromDatetime(self.last_updated_timestamp)
 
         spec = EntitySpecProto(
             name=self.name,
@@ -249,5 +241,5 @@ def _update_from_entity(self, entity):
         self.value_type = entity.value_type
         self.labels = entity.labels
         self.join_key = entity.join_key
-        self._created_timestamp = entity.created_timestamp
-        self._last_updated_timestamp = entity.last_updated_timestamp
+        self.created_timestamp = entity.created_timestamp
+        self.last_updated_timestamp = entity.last_updated_timestamp

sdk/python/feast/feature_service.py

@@ -32,7 +32,7 @@ class FeatureService:
 
     name: str
     feature_view_projections: List[FeatureViewProjection]
-    description: str
+    description: Optional[str] = None
     tags: Dict[str, str]
     created_timestamp: Optional[datetime] = None
     last_updated_timestamp: Optional[datetime] = None

sdk/python/feast/infra/utils/snowflake_utils.py

@@ -43,29 +43,27 @@ def get_snowflake_conn(config, autocommit=True) -> SnowflakeConnection:
     if config.type == "snowflake.offline":
         config_header = "connections.feast_offline_store"
 
-    config = dict(config)
+    config_dict = dict(config)
 
     # read config file
     config_reader = configparser.ConfigParser()
-    config_reader.read([config["config_path"]])
+    config_reader.read([config_dict["config_path"]])
     if config_reader.has_section(config_header):
         kwargs = dict(config_reader[config_header])
     else:
         kwargs = {}
 
-    kwargs.update((k, v) for k, v in config.items() if v is not None)
+    kwargs.update((k, v) for k, v in config_dict.items() if v is not None)
+    [
+        kwargs.update({k: '"' + v + '"'})
+        for k, v in kwargs.items()
+        if k in ["role", "warehouse", "database", "schema_"]
+    ]
+    kwargs["schema"] = kwargs.pop("schema_")
 
     try:
         conn = snowflake.connector.connect(
-            account=kwargs["account"],
-            user=kwargs["user"],
-            password=kwargs["password"],
-            role=f'''"{kwargs['role']}"''',
-            warehouse=f'''"{kwargs['warehouse']}"''',
-            database=f'''"{kwargs['database']}"''',
-            schema=f'''"{kwargs['schema_']}"''',
-            application="feast",
-            autocommit=autocommit,
+            application="feast", autocommit=autocommit, **kwargs
         )
 
         return conn