Skip to content

Commit 9f1cc54

Browse files
committed
add project name to validation metric
Signed-off-by: Oleksii Moskalenko <moskalenko.alexey@gmail.com>
1 parent e8d8b72 commit 9f1cc54

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

sdk/python/feast/contrib/validation/ge.py

+1
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ def udf(df: pd.DataFrame) -> pd.Series:
131131
value=unexpected_count,
132132
tags=[
133133
f"feature_table:{os.getenv('FEAST_INGESTION_FEATURE_TABLE', 'unknown')}",
134+
f"project:{os.getenv('FEAST_INGESTION_PROJECT_NAME', 'default')}",
134135
f"check:{check_name}",
135136
],
136137
)

spark/ingestion/src/main/scala/feast/ingestion/StreamingPipeline.scala

+2-1
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,8 @@ object StreamingPipeline extends BasePipeline with Serializable {
176176
Map(
177177
"STATSD_HOST" -> c.host,
178178
"STATSD_PORT" -> c.port.toString,
179-
"FEAST_INGESTION_FEATURE_TABLE" -> config.featureTable.name
179+
"FEAST_INGESTION_FEATURE_TABLE" -> config.featureTable.name,
180+
"FEAST_INGESTION_PROJECT_NAME" -> config.featureTable.project
180181
)
181182
case _ => Map.empty[String, String]
182183
}

tests/e2e/test_validation.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,8 @@ def test_validation_reports_metrics(
200200

201201
expected_metrics = [
202202
(
203-
f"feast_feature_validation_check_failed#check:{check_name},feature_table:validation_ge_metrics",
203+
f"feast_feature_validation_check_failed#check:{check_name},"
204+
f"feature_table:{feature_table.name},project:{feast_client.project}",
204205
value,
205206
)
206207
for check_name, value in unexpected_counts.items()

0 commit comments

Comments
 (0)