Skip to content

Commit 5f126fb

Browse files
authored
Preserve ordering of features in _get_column_names
1 parent 356788a commit 5f126fb

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

sdk/python/feast/infra/provider.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -290,9 +290,10 @@ def _get_column_names(
290290

291291
# We need to exclude join keys and timestamp columns from the list of features, after they are mapped to
292292
# their final column names via the `field_mapping` field of the source.
293-
_feature_names = set(feature_names) - set(join_keys)
294-
_feature_names = _feature_names - {event_timestamp_column, created_timestamp_column}
295-
feature_names = list(_feature_names)
293+
feature_names = [name for name in feature_names
294+
if name not in join_keys
295+
and not event_timestamp_column
296+
and not created_timestamp_column]
296297
return (
297298
join_keys,
298299
feature_names,

0 commit comments

Comments
 (0)