Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(domain): use strings.CutPrefix #383

Merged
merged 3 commits into from
Feb 6, 2023
Merged

refactor(domain): use strings.CutPrefix #383

merged 3 commits into from
Feb 6, 2023

Conversation

favonia
Copy link
Owner

@favonia favonia commented Feb 2, 2023

@favonia favonia force-pushed the go1.20 branch 3 times, most recently from c410563 to 02972a8 Compare February 2, 2023 12:18
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #383 (692f36d) into main (1519e20) will increase coverage by 9.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   87.89%   97.40%   +9.50%     
==========================================
  Files          32       30       -2     
  Lines        2049     1850     -199     
==========================================
+ Hits         1801     1802       +1     
+ Misses        236       36     -200     
  Partials       12       12              
Flag Coverage Δ
unittests 97.40% <100.00%> (+9.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/domainexp/parser.go 100.00% <ø> (ø)
internal/domain/domain.go 100.00% <100.00%> (ø)
cmd/ddns/ddns.go
internal/droproot/drop.go

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@favonia favonia force-pushed the go1.20 branch 7 times, most recently from aed8837 to a4ce3a7 Compare February 3, 2023 06:02
@favonia
Copy link
Owner Author

favonia commented Feb 3, 2023

Everything works except that the coverage data generated by Go 1.20 are off: packages without test files do not appear in the coverage report even with -coverpkg.

@favonia favonia added the blocked This issue or pull request is blocked by something outside the authors' control label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue or pull request is blocked by something outside the authors' control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CutPrefix when Go 1.20 is out
1 participant