Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click on expanded image #68

Open
CliffS opened this issue Jan 11, 2016 · 3 comments
Open

Right click on expanded image #68

CliffS opened this issue Jan 11, 2016 · 3 comments

Comments

@CliffS
Copy link

CliffS commented Jan 11, 2016

I got complaints from my users that they would expect right-click to work on the image while it's expanded. Currently it simply closes the zoom.

I simply added one line to _clickHandler:

    if (e.which == 3) return

Would you like a PR, do you disagree with the change or would you like me to add it in as an option?

@spinningarrow
Copy link

Seems to be working fine, at least on Chrome 48 on OS X. Which browser and OS are you on?

image

@CliffS
Copy link
Author

CliffS commented Feb 1, 2016

On 01/02/16 13:14, Sahil Bajaj wrote:

Seems to be working fine, at least on Chrome 48 on OS X. Which browser
and OS are you on?

Ubuntu 15.10 and Firefox 44.0.

What happens currently is that the right click is seen as a click and
causes the enlarged image to close.

Cliff Stanford
London: +44 20 0222 1666
Swansea: +44 1792 469 666
Mobile: +44 7973 616 666

@spinningarrow
Copy link

Looks like a Firefox issue - I tried it just now and though I see the context menu, the image does zoom out as you described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant