Implement GPA score #100
Implement GPA score #100
Conversation
I'm trying to follow the [GPA (grade point average)](https://bigfuture.collegeboard.org/plan-for-college/college-basics/how-to-convert-gpa-4.0-scale) but the example there used the 4.0 scale, and I'm not pretty sure if we want that. Closes #95
JuanVqz
requested review from
mateusdeap and
KostiantynPopovych
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 25 25
Lines 463 463
=======================================
Hits 455 455
Misses 8 8 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Have a question, The range that I used was found on the internet but it will be great if you can confirm that it is the correct one. Ex. of a simplified version. # |Letter Grade | Percent Grade | Scale |
# |:------------|:-------------:|------:|
# | A | 0-69 | 4.0 |
# | B | 70-79 | 3.0 |
# | C | 80-89 | 2.0 |
# | D | 90-96 | 1.0 |
# | E/F | 97-INFINITY | 0.0 |
def score
case @skunk_score
when (0..69)
"A"
when (70..79)
"B"
when (80..89)
"C"
when (90..96)
"D"
when (97..Float::INFINITY)
"E"
end
endI haven't fixed the linter because we may modify the logic there. |
|
Hey guys! Loving this idea! @etagwerker requested some real world results to work against, so here's the top 20 scores from a recent run at our place (sans the file names). We literally have hundreds of files this runs against, so if you need deeper data, let me know! | 1390.66 | 76.41 | 5 | 15.28 | 9.8 | |
@JuanVqz I don't think we are interested in this at the moment: |
I'm going to close this pr, I think we give it a shot later, thanks @etagwerker |
CHANGELOG.mdthat links to this PR under the "main (unreleased)" heading.Description:
I'm trying to solve #95 following the GPA (grade point average) score
but the example there used the 4.0 scale and I'm not pretty sure if we
want that.
Closes #95
If changes to the behavior are made, clearly describe what changes.
I will abide by the code of conduct.