Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache setting is missing the 'deliver' action #136

Closed
jsierles opened this issue Dec 5, 2019 · 1 comment
Closed

Cache setting is missing the 'deliver' action #136

jsierles opened this issue Dec 5, 2019 · 1 comment

Comments

@jsierles
Copy link

jsierles commented Dec 5, 2019

Fastly supports 'deliver' in its UI for cache settings, so this provider should add the option as well as cache, pass and restart.

Screen Shot 2019-12-05 at 12 34 53

@Integralist
Copy link
Collaborator

Hi @jsierles thanks for opening this issue (and your patience waiting for a reply).

Upon investigating the available actions in the UI we find that the 'Deliver' option is in fact passing a value of 'cache':

Screenshot 2021-01-06 at 13 34 20

Which is already supported in Go-Fastly:

const (
// CacheSettingActionCache sets the cache to cache.
CacheSettingActionCache CacheSettingAction = "cache"
// CacheSettingActionPass sets the cache to pass through.
CacheSettingActionPass CacheSettingAction = "pass"
// CacheSettingActionRestart sets the cache to restart the request.
CacheSettingActionRestart CacheSettingAction = "restart"
)

If you have any further queries then please just let me know. I'll leave this issue open for a little longer to give you a chance to review and either close it yourself or raise questions, otherwise if there is no further discussion required by the end of the week I'll close this issue.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants