Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Improve detection for images when running in sudo or ssh #839

Closed
Thelvaen opened this issue May 2, 2024 · 8 comments
Closed

[FEAT] Improve detection for images when running in sudo or ssh #839

Thelvaen opened this issue May 2, 2024 · 8 comments
Labels
can't reproduce enhancement New feature or request need more info Further information needed

Comments

@Thelvaen
Copy link

Thelvaen commented May 2, 2024

Wanted features:

When accessing a computer through ssh or changing user through sudo, png logos are not displayed properly.

Motivation:

having the fallback to the ASCII version of the logo would be nicer than just having PNG written at the top of the output.

@Thelvaen Thelvaen added the enhancement New feature or request label May 2, 2024
@1ivyatan
Copy link

1ivyatan commented May 2, 2024

So, like a PNG turns into ASCII art as a fallback?

@Thelvaen
Copy link
Author

Thelvaen commented May 2, 2024

probably easier to understand what I mean through screenshots.
in sudo
image
in ssh
image
I'd rather have something like that:
image

@CarterLi
Copy link
Member

CarterLi commented May 2, 2024

The escape code may need to be wrapped. Will investigate it later

@CarterLi
Copy link
Member

CarterLi commented May 2, 2024

Does neofetch work in this case?

@Thelvaen
Copy link
Author

Thelvaen commented May 2, 2024

when using sudo it works, when ran through SSH it does not show the image, but properly fallback to the ascii art version of the logo.

@CarterLi
Copy link
Member

CarterLi commented May 3, 2024

Should be fixed in 71cba24

@CarterLi CarterLi closed this as completed May 3, 2024
@CarterLi CarterLi reopened this May 4, 2024
@CarterLi
Copy link
Member

CarterLi commented May 4, 2024

Commit reverted.

Image logos in SSH session do work for me

image

@CarterLi
Copy link
Member

CarterLi commented May 4, 2024

sudo works too

image

@CarterLi CarterLi added can't reproduce need more info Further information needed labels May 10, 2024
@CarterLi CarterLi closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can't reproduce enhancement New feature or request need more info Further information needed
Projects
None yet
Development

No branches or pull requests

3 participants