Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when
max_length
is specified in aField
, it has no real effect on the corresponding SQL schema (#126, #746). As pointed out by @chris-beedie, this is because the configuredmax_length
is stored as anannotated_types.MaxLen
, rather than aPydanticMetadata
object, and is therefore ignored inget_field_metadata
.This PR adds a simple extra check for that specific case. I have confirmed it works using PostgreSQL 16.2.
I also wanted to write a test for it, along the following lines:
Unfortunately, this doesn't work, as
sqlite
does not actually enforce something likeVARCHAR(5)
.One solution would be to use a
testcontainer
(see here) to run a PostgreSQL instance and test against that, but it would significantly increase the complexity & dependencies of the unit tests.