Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically decode response based on path #183

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Automatically decode response based on path #183

merged 2 commits into from
Aug 31, 2024

Conversation

radam9
Copy link
Contributor

@radam9 radam9 commented Aug 31, 2024

This PR fixes #157

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@radam9
Copy link
Contributor Author

radam9 commented Aug 31, 2024

@jph00 There is one failing test, but that was failing before I made any changes.
let me know what you think.

@jph00 jph00 merged commit 2093545 into AnswerDotAI:master Aug 31, 2024
@jph00
Copy link
Contributor

jph00 commented Aug 31, 2024

Great job!

@jph00 jph00 changed the title fix UnicodeDecodeError when downloading non-json content Automatically decode response based on path Aug 31, 2024
@jph00 jph00 added the enhancement New feature or request label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UnicodeDecodeError on repos.download_tarball_archive
2 participants