Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems and missing features with installation and upload. #3

Closed
ozgurceozturkce opened this issue Jan 14, 2023 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@ozgurceozturkce
Copy link

Hello, first of all, I would like to thank you for your efforts for this beautiful project work.
Let me get right to the point;

First of all, while creating a new table as I mentioned below on line 194 of ../logic/installLogic.php during the installation process, the table name is defined as  role .

$install->createTable("role", $role);

However, again on line 373 of ../logic/installLogic.php (and a few more lines) it is defined as  roles  as in the example I added below.

$install->insertValue("roles", [
            'id' => 2,
            'role' => 'User',
            'size_limit' => '150 MB',
        ]);

These differences cause the initial installation to fail.

Another problem is related to the  downloads  field, which is in the  files  table on line 58 of ../src/Uploady/Handler/UploadHandler.php but is not specified here.

The problem in this area is when uploading. Since the field does not have a default value when the table is first created, executing the code at line 64 after this code section results in an error that the file has no default value while saving it to the database. The file is uploaded but not saved in the database.

These are the problems I see so far. I hope I explained it in a proper and understandable English and it was useful for you.

I will not be able to use your project because it does not have the feature of specifying the file sharing period and the automatic deletion of the file at the end of this period, but I liked it. Built with a simple, beautiful configuration. Editing is easy.

Finally, thank you again for your work. Good luck.

Hello, first of all, I would like to thank you for your efforts for this beautiful project work.
Let me get right to the point;

First of all, while creating a new table as I mentioned below on line 194 of ../logic/installLogic.php during the installation process, the table name is defined as  role .

$install->createTable("role", $role);

However, again on line 373 of ../logic/installLogic.php (and a few more lines) it is defined as  roles  as in the example I added below.

$install->insertValue("roles", [
            'id' => 2,
            'role' => 'User',
            'size_limit' => '150 MB',
        ]);

These differences cause the initial installation to fail.

Another problem is related to the  downloads  field, which is in the  files  table on line 58 of ../src/Uploady/Handler/UploadHandler.php but is not specified here.

The problem in this area is when uploading. Since the field does not have a default value when the table is first created, executing the code at line 64 after this code section results in an error that the file has no default value while saving it to the database. The file is uploaded but not saved in the database.

These are the problems I see so far. I hope I explained it in a proper and understandable English and it was useful for you.

I will not be able to use your project because it does not have the feature of specifying the file sharing period and the automatic deletion of the file at the end of this period, but I liked it. Built with a simple, beautiful configuration. Editing is easy.

Finally, thank you again for your work. Good luck.

@farisc0de
Copy link
Owner

I am so sorry for the typo and thank you for pointing it out, I'll fix it right away.

@ozgurceozturkce
Copy link
Author

We're all human, we make mistakes. I also do it very often. The important thing is to fix it. Thank you for your understanding and quick response.

@farisc0de
Copy link
Owner

farisc0de commented Jan 15, 2023

The feature you specified is interesting, and I will add it to the development plan.

@farisc0de farisc0de self-assigned this Jan 15, 2023
@farisc0de farisc0de added the bug Something isn't working label Jan 15, 2023
@rpcob rpcob mentioned this issue Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants