Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The game session crashes for everyone when entering with a name containing emoji #160

Closed
SirMarwin opened this issue Nov 21, 2020 · 2 comments · Fixed by #158
Closed

The game session crashes for everyone when entering with a name containing emoji #160

SirMarwin opened this issue Nov 21, 2020 · 2 comments · Fixed by #158
Assignees
Labels
bug Something isn't working

Comments

@SirMarwin
Copy link

🚩 Describe the bug

When joining a game session as a player I did enter a name followed by 🐺 emoji. The game crashed for me and others reported crashes as well.

🔢 Steps to reproduce

  1. Go to a game link provided by GM
  2. enter "Bob 🐺" as your name
  3. press enter
  4. The session will crash (for you as well as other connected player(s)

🟢 Expected behavior

When using emoji in character name, this will be displayed to everyone

🔴 Actual behavior

Entering emoji in character name crashes and forces reload

🖥 Desktop or Smartphone

  • OS: Win
  • Browser: Chrome and firefox
@SirMarwin SirMarwin added the bug Something isn't working label Nov 21, 2020
@RPDeshaies
Copy link
Collaborator

Woa! Good catch there! There is indeed a bug!

I found a solution, will do some testing in the next couple of days and write some tests to make sure it doesn't happen anymore

@RPDeshaies
Copy link
Collaborator

Will be released with #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

2 participants