Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The sort button only sort pinned index cards and does not sort by index card categories #177

Closed
RPDeshaies opened this issue Dec 19, 2020 · 0 comments
Closed

The sort button only sort pinned index cards and does not sort by index card categories #177

RPDeshaies opened this issue Dec 19, 2020 · 0 comments
Assignees
@RPDeshaies
Labels
bug Something isn't working

Comments

@RPDeshaies
Copy link
Collaborator

🚩 Describe the bug

As noted here #176, the sort button doesn't work anymore and just takes in consideration pinned items and not index card types

🔢 Steps to reproduce

  • Start a new online game
  • Add a bad guy
  • Add a boost
  • Add an aspect
  • Click on the sort button

🟢 Expected behavior

The items should be sorted as aspect => boost => bad guy

🔴 Actual behavior

Nothing happens except if you pinned one index cards

💅 Screenshots

...

🖥 Desktop or Smartphone

  • OS: [e.g. iOS]
  • Browser: [e.g. chrome, safari]
  • Device: [e.g. iPhone6]

📄 Additional context

...
@RPDeshaies RPDeshaies added the bug Something isn't working label Dec 19, 2020
@RPDeshaies RPDeshaies self-assigned this Dec 19, 2020
@RPDeshaies RPDeshaies modified the milestones: v4.0.0, v3.3.9 Dec 19, 2020
RPDeshaies added a commit that referenced this issue Dec 19, 2020
@RPDeshaies
fix: The sort button only sort pinned index cards and does not sort b…
88719d1 
…y index card categories #177
@RPDeshaies RPDeshaies mentioned this issue Dec 19, 2020
Merged
RPDeshaies added a commit that referenced this issue Dec 21, 2020
@RPDeshaies
feat: v.3.3.9 (block scene reload, sort fix button, join game with ne…
0a28260 
…w character) (#181)

fix: block reload when playing a Scene #178
fix: sort button #177
feat: join a game using the Add or Import character buttons
feat: scene name help text
feat: basic print mode for character sheets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RPDeshaies RPDeshaies

Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RPDeshaies